lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Jan 2016 15:58:48 -0500 (EST) From: Alan Stern <stern@...land.harvard.edu> To: "Geyslan G. Bem" <geyslan@...il.com> cc: linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org> Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > This patch fixes coding style issues reported by checkpatch concerning > to unnecessary space after a cast. This is a case where checkpatch is wrong, IMO. Casts should always be followed by a space. I will not accept this patch. This must be something recently added to checkpatch. It never used to complain about casts, whether they were followed by a space or not. Alan Stern > Signed-off-by: Geyslan G. Bem <geyslan@...il.com> > --- > drivers/usb/host/ehci-dbg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c > index 1645120..edae79e 100644 > --- a/drivers/usb/host/ehci-dbg.c > +++ b/drivers/usb/host/ehci-dbg.c > @@ -123,7 +123,7 @@ dbg_qh(const char *label, struct ehci_hcd *ehci, struct ehci_qh *qh) > > ehci_dbg(ehci, "%s qh %p n%08x info %x %x qtd %x\n", label, > qh, hw->hw_next, hw->hw_info1, hw->hw_info2, hw->hw_current); > - dbg_qtd("overlay", ehci, (struct ehci_qtd *) &hw->hw_qtd_next); > + dbg_qtd("overlay", ehci, (struct ehci_qtd *)&hw->hw_qtd_next); > } > > static void __maybe_unused > @@ -491,7 +491,7 @@ static void qh_lines( > (scratch >> 16) & 0x7fff, > scratch, > td->urb, > - (u32) td->qtd_dma, > + (u32)td->qtd_dma, > hc32_to_cpup(ehci, &td->hw_buf[0])); > if (size < temp) > temp = size; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists