linux-kernel - Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jan 2016 00:52:10 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	LKML <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after
 cast

Hello.

On 01/05/2016 12:49 AM, Greg Kroah-Hartman wrote:

>>>> This patch fixes coding style issues reported by checkpatch concerning
>>>> to unnecessary space after a cast.
>>>
>>> This is a case where checkpatch is wrong, IMO.  Casts should always be
>>> followed by a space.  I will not accept this patch.
>> Ok. I understand.
>>
>>>
>>> This must be something recently added to checkpatch.  It never used to
>>> complain about casts, whether they were followed by a space or not.
>> I'm using the checkpatch --strict option.
>
> Please never use that on existing kernel code, except for
> drivers/staging/ stuff, otherwise your patches will start to very
> quickly be ignored.

    Just wanted to remind everybody that this option is forced when checking 
the networking code...

> thanks,
>
> greg k-h

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/