linux-kernel - RE: [PATCH RESEND] megaraid:Fix for loop termination statment in the function process_fw_state_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <25ea254d9eb153f31d92edd78da0d790@mail.gmail.com>
Date:	Mon, 4 Jan 2016 11:11:02 +0530
From:	Sumit Saxena <sumit.saxena@...gotech.com>
To:	Nicholas Krause <xerofoify@...il.com>,
	Kashyap Desai <kashyap.desai@...gotech.com>
Cc:	Uday Lingala <uday.lingala@...gotech.com>, JBottomley@...n.com,
	martin.petersen@...cle.com,
	"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...gotech.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH RESEND] megaraid:Fix for loop termination statment in the
 function process_fw_state_change_wq

> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Friday, January 01, 2016 12:06 PM
> To: kashyap.desai@...gotech.com
> Cc: sumit.saxena@...gotech.com; uday.lingala@...gotech.com;
> JBottomley@...n.com; martin.petersen@...cle.com;
> megaraidlinux.pdl@...gotech.com; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH RESEND] megaraid:Fix for loop termination statment in
the
> function process_fw_state_change_wq
>
> This fixes the for loop terimation for the waiting period between the
first and
> second init to make the variable wait terminate at the value of 20
rather then 30
> in other to follow the comments about this for loop of waiting for about
20
> seconds rather then
> 30 in the function fw_state_change_wq between initializations.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 71b884d..22fd333 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -3168,9 +3168,8 @@ process_fw_state_change_wq(struct work_struct
> *work)
>  					"state 2 starting...\n");
>
>  		/*waitting for about 20 second before start the second
init*/
> -		for (wait = 0; wait < 30; wait++) {
> +		for (wait = 0; wait < 20; wait++)
>  			msleep(1000);
> -		}
>
>  		if (megasas_transition_to_ready(instance, 1)) {
>  			printk(KERN_NOTICE "megaraid_sas:adapter not
> ready\n");

There should be 30 seconds delay here, comments needs to be rectified
here. I will take care of this in next patch set.
> --
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/