linux-kernel - Re: [PATCH v3 09/17] drivers: Initialize resource entry to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <568C2E3D.4060701@gmx.de>
Date:	Tue, 5 Jan 2016 21:57:33 +0100
From:	Helge Deller <deller@....de>
To:	Toshi Kani <toshi.kani@....com>, akpm@...ux-foundation.org,
	bp@...en8.de
Cc:	linux-arch@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH v3 09/17] drivers: Initialize resource entry to zero

On 05.01.2016 19:54, Toshi Kani wrote:
> I/O resource descriptor, 'desc' in struct resource, needs to be
> initialized to zero by default.  Some drivers call kmalloc() to
> allocate a resource entry, but does not initialize it to zero by
> memset().  Change these drivers to call kzalloc(), instead.
> 
> Cc: linux-acpi@...r.kernel.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linux-sh@...r.kernel.org
> Acked-by: Simon Horman <horms+renesas@...ge.net.au> # sh
> Signed-off-by: Toshi Kani <toshi.kani@....com>
> ---
>  drivers/acpi/acpi_platform.c       |    2 +-
>  drivers/parisc/eisa_enumerator.c   |    4 ++--

The parisc changes look good. For those:
Acked-by: Helge Deller <deller@....de>



>  drivers/rapidio/rio.c              |    8 ++++----
>  drivers/sh/superhyway/superhyway.c |    2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 296b7a1..b6f7fa3 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
>  	if (count < 0) {
>  		return NULL;
>  	} else if (count > 0) {
> -		resources = kmalloc(count * sizeof(struct resource),
> +		resources = kzalloc(count * sizeof(struct resource),
>  				    GFP_KERNEL);
>  		if (!resources) {
>  			dev_err(&adev->dev, "No memory for resources\n");
> diff --git a/drivers/parisc/eisa_enumerator.c b/drivers/parisc/eisa_enumerator.c
> index a656d9e..21905fe 100644
> --- a/drivers/parisc/eisa_enumerator.c
> +++ b/drivers/parisc/eisa_enumerator.c
> @@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf,
>  	for (i=0;i<HPEE_MEMORY_MAX_ENT;i++) {
>  		c = get_8(buf+len);
>  		
> -		if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> +		if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
>  			int result;
>  			
>  			res->name = name;
> @@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, struct resource *io_parent,
>  	for (i=0;i<HPEE_PORT_MAX_ENT;i++) {
>  		c = get_8(buf+len);
>  		
> -		if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> +		if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
>  			res->name = board;
>  			res->start = get_16(buf+len+1);
>  			res->end = get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1;
> diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
> index d7b87c6..e220edc 100644
> --- a/drivers/rapidio/rio.c
> +++ b/drivers/rapidio/rio.c
> @@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport,
>  	if (mport->ops->open_inb_mbox == NULL)
>  		goto out;
>  
> -	res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +	res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>  
>  	if (res) {
>  		rio_init_mbox_res(res, mbox, mbox);
> @@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport,
>  	if (mport->ops->open_outb_mbox == NULL)
>  		goto out;
>  
> -	res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +	res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>  
>  	if (res) {
>  		rio_init_mbox_res(res, mbox, mbox);
> @@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport,
>  {
>  	int rc = 0;
>  
> -	struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +	struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>  
>  	if (res) {
>  		rio_init_dbell_res(res, start, end);
> @@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 start, u16 end)
>  struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start,
>  					u16 end)
>  {
> -	struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +	struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>  
>  	if (res) {
>  		rio_init_dbell_res(res, start, end);
> diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/superhyway.c
> index 2d9e7f3..bb1fb771 100644
> --- a/drivers/sh/superhyway/superhyway.c
> +++ b/drivers/sh/superhyway/superhyway.c
> @@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev,
>  	superhyway_read_vcr(dev, base, &dev->vcr);
>  
>  	if (!dev->resource) {
> -		dev->resource = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +		dev->resource = kzalloc(sizeof(struct resource), GFP_KERNEL);
>  		if (!dev->resource) {
>  			kfree(dev);
>  			return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/