linux-kernel - Re: [PATCH] fuse: implement cuse mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Jan 2016 13:19:24 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	<luca.risolia@...dio.unibo.it>
Cc:	"Jader H. Silva" <jaderhs5@...il.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fuse: implement cuse mmap

On Tue, 5 Jan 2016 21:21:16 +0100 Luca Risolia <luca.risolia@...dio.unibo.it> wrote:

> I was wondering if there's a chance to have this patch merged anytime 
> soon. Note that FUSE maintainer left off sometime ago and there's no one 
> taking care of kernel patches at the moment.
> 
> Please let Jader and me know if there are any problems.

I didn't know that FUSE maintainership had altered.

At -rc8 isn't a convenient time - please resend after 4.5-rc1.  I of
course *could* merge the patch now and hold it off for the 4.6 merge
window, but...

Please write a much more complete changelog.  Much.  What are the
objectives, why do we need this feature.  How did you choose to
implement the feature.  Are there alternative ways of implementing it
and if so, why did you choose this way, etc.

Also, the code is poorly commented.  Please fix that, concentrating
less on *what* the code is doing and more on *why* it is doing it. 
Tell the reader what you're trying to achieve.  Tell the reader those
things which aren't discernible from the code itself.

Documenting the data structures is particularly important.  In kernel
code, if that is done well enough then the code itself tends to become
rather obvious.  Like, what's going on with this vm_original_ops thing?
hm, that's a bit of a head-scratcher at present.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/