linux-kernel - Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160105103820.GA5133@krava.brq.redhat.com>
Date:	Tue, 5 Jan 2016 11:38:20 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint
 events

On Mon, Dec 21, 2015 at 11:26:48PM +0900, Namhyung Kim wrote:

SNIP

> +	free(str);
> +	return ret;
> +}
> +
>  static int __sort_dimension__add(struct sort_dimension *sd)
>  {
>  	if (sd->taken)
> @@ -1667,6 +1887,9 @@ static int sort_dimension__add(const char *tok,

sort_dimension__add's evlist arg could loose the '__maybe_unused' now

thanks,
jirka

>  		return 0;
>  	}
>  
> +	if (!add_dynamic_entry(evlist, tok))
> +		return 0;
> +
>  	return -ESRCH;
>  }
>  
> -- 
> 2.6.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/