linux-kernel - Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160105105857.GA3718@pd.tnic>
Date:	Tue, 5 Jan 2016 11:58:57 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Thor Thayer <tthayer@...nsource.altera.com>
Cc:	Dinh Nguyen <dinguyen@...nsource.altera.com>, dinh.linux@...il.com,
	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux@....linux.org.uk, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC
 Support

On Mon, Jan 04, 2016 at 05:42:40PM -0600, Thor Thayer wrote:
> and then the defines are also used to conditionally include the L2 or OCRAM
> ECC functions because everything is in one file.

So?

You don't have to do those funny games in the Makefile. Instead, you
have your main CONFIG_EDAC_ALTERA_MC option and all the other CONFIG_*
options depend on it. The ifdeffery in altera_edac.c then takes care of
what needs to be enabled or not.

However(!), your driver is not huge or something. So I still don't
understand why you need that split and those additional config options
and why not keep it all together in one file. What is the compelling use
case for that split and additional complexity?

> However, the highbank and octeon edacs are split into separate files for L2
> which Dinh pointed may be cleaner for individual control.

I should've nacked that split at the time.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/