| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jan 2016 12:44:54 +0100 From: Hans de Goede <hdegoede@...hat.com> To: Pali Rohár <pali.rohar@...il.com>, Jeremiah Mahler <jmmahler@...il.com>, linux-kernel@...r.kernel.org, Henrique de Moraes Holschuh <ibm-acpi@....eng.br>, Darren Hart <dvhart@...radead.org> Subject: Re: thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference Hi all, On 05-01-16 09:17, Pali Rohár wrote: > Hello, > > looks like this fault is in acpi video module, not in thinkpad. CCing > Hans who introduced this acpi video brightness key change. > > Hans, can you look at this bug? Pali thanks for bringing this to my attention. Adrien Schildknecht has already posted a fix for this, I've added all people receiving this mail to the Cc for my reply (my ack) for Adrien's fix. Regards, Hans > > On Monday 04 January 2016 18:33:47 Jeremiah Mahler wrote: >> all, >> >> Just tried linux-next 20160104 on a Lenovo Carbon X1 and I got a BUG >> message about a NULL pointer dereference. There is also a WARNING about >> a mutex (see below). It looks like it might be related to something in >> the thinkpad_acpi module. >> >> [...] >> [ 2.374627] thinkpad_acpi: ThinkPad ACPI Extras v0.25 >> [ 2.374630] thinkpad_acpi: http://ibm-acpi.sf.net/ >> [ 2.374632] thinkpad_acpi: ThinkPad BIOS G6ET59WW (2.03 ), EC unknown >> [ 2.374633] thinkpad_acpi: Lenovo ThinkPad X1 Carbon, model 3443CTO >> [ 2.375176] thinkpad_acpi: Unsupported brightness interface >> [ 2.375303] thinkpad_acpi: radio switch found; radios are enabled >> [ 2.375317] ------------[ cut here ]------------ >> [ 2.375384] WARNING: CPU: 1 PID: 303 at kernel/locking/mutex.c:526 __mutex_lock_slowpath+0x2d8/0x2f0() >> [ 2.375453] DEBUG_LOCKS_WARN_ON(l->magic != l) >> [ 2.375503] Modules linked in: >> [ 2.375592] battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal >> [ 2.377790] CPU: 1 PID: 303 Comm: systemd-udevd Not tainted 4.4.0-rc7-next-20160104+ #2 >> [ 2.377888] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 >> [ 2.377984] ffffffff81722534 ffffffff812d0967 ffff880035e07ae0 ffffffff8106ad7d >> [ 2.378269] ffffffffa0381360 ffff880035e07b30 ffffffffa0381368 ffff8801181ef100 >> [ 2.378550] ffffffffa03ea348 ffffffff8106adfc ffffffff8172251c 0000000000000020 >> [ 2.378817] Call Trace: >> [ 2.378895] [<ffffffff812d0967>] ? dump_stack+0x40/0x59 >> [ 2.378971] [<ffffffff8106ad7d>] ? warn_slowpath_common+0x7d/0xb0 >> [ 2.379033] [<ffffffff8106adfc>] ? warn_slowpath_fmt+0x4c/0x50 >> [ 2.379109] [<ffffffff81236053>] ? kernfs_add_one+0x103/0x160 >> [ 2.379185] [<ffffffff814f8858>] ? __mutex_lock_slowpath+0x2d8/0x2f0 >> [ 2.379262] [<ffffffff814f8886>] ? mutex_lock+0x16/0x30 >> [ 2.379343] [<ffffffffa037a363>] ? acpi_video_handles_brightness_key_presses+0x12/0x40 [video] >> [ 2.379427] [<ffffffffa03e73c1>] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] >> [ 2.379502] [<ffffffffa03e8402>] ? thinkpad_acpi_module_init.part.32+0x5f6/0x925 [thinkpad_acpi] >> [ 2.379598] [<ffffffffa03e8731>] ? thinkpad_acpi_module_init.part.32+0x925/0x925 [thinkpad_acpi] >> [ 2.379693] [<ffffffffa03e8a83>] ? thinkpad_acpi_module_init+0x352/0x8cf [thinkpad_acpi] >> [ 2.379799] [<ffffffff8115092b>] ? free_pcppages_bulk+0xbb/0x480 >> [ 2.379871] [<ffffffff81002122>] ? do_one_initcall+0xb2/0x200 >> [ 2.379947] [<ffffffff8114846b>] ? do_init_module+0x5b/0x1e0 >> [ 2.380012] [<ffffffff810e366e>] ? load_module+0x220e/0x2810 >> [ 2.380079] [<ffffffff810dff70>] ? __symbol_put+0x30/0x30 >> [ 2.380147] [<ffffffff810e3e50>] ? SyS_finit_module+0x90/0xc0 >> [ 2.380219] [<ffffffff814fa832>] ? entry_SYSCALL_64_fastpath+0x16/0x71 >> [ 2.380296] ---[ end trace 60661306144c0866 ]--- >> [ 2.380374] BUG: unable to handle kernel NULL pointer dereference at (null) >> [ 2.380552] IP: [<ffffffff814f8655>] __mutex_lock_slowpath+0xd5/0x2f0 >> [ 2.380682] PGD 0 >> [ 2.380795] Oops: 0002 [#1] SMP >> [ 2.380968] Modules linked in: battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal >> [ 2.383278] CPU: 1 PID: 303 Comm: systemd-udevd Tainted: G W 4.4.0-rc7-next-20160104+ #2 >> [ 2.383358] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 >> [ 2.383455] task: ffff8801181ef100 ti: ffff880035e04000 task.ti: ffff880035e04000 >> [ 2.383547] RIP: 0010:[<ffffffff814f8655>] [<ffffffff814f8655>] __mutex_lock_slowpath+0xd5/0x2f0 >> [ 2.383634] ACPI: Battery Slot [BAT0] (battery present) >> [ 2.383706] RSP: 0018:ffff880035e07b40 EFLAGS: 00010002 >> [ 2.383761] RAX: 0000000000000000 RBX: ffffffffa0381360 RCX: ffffffffa0381380 >> [ 2.383820] RDX: 0000000000000000 RSI: ffff880035e07b50 RDI: ffffffffa0381360 >> [ 2.383874] RBP: ffff880035e07ba0 R08: 0000000000000000 R09: 00000000000002c4 >> [ 2.383924] R10: ffffffff81a85600 R11: 00000000000002c4 R12: ffffffffa0381368 >> [ 2.383975] R13: ffff8801181ef100 R14: 00000000ffffffff R15: 0000000000000246 >> [ 2.384026] FS: 00007f1c1743a8c0(0000) GS:ffff88011e280000(0000) knlGS:0000000000000000 >> [ 2.384087] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> [ 2.384136] CR2: 0000000000000000 CR3: 0000000035fa6000 CR4: 00000000001406e0 >> [ 2.384186] Stack: >> [ 2.384230] ffff8800c76612f8 ffffffffa0381380 ffffffffa0381380 0000000000000000 >> [ 2.384419] 1111111111111111 ffff880035e07b50 ffff8800c9ea1800 ffffffffa0381360 >> [ 2.384607] 0000000000000001 0000000000000001 ffffffffa03ea348 ffffffffa03e1c60 >> [ 2.384799] Call Trace: >> [ 2.384846] [<ffffffff814f8886>] ? mutex_lock+0x16/0x30 >> [ 2.384896] [<ffffffffa037a363>] ? acpi_video_handles_brightness_key_presses+0x12/0x40 [video] >> [ 2.384961] [<ffffffffa03e73c1>] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] >> [ 2.385014] [<ffffffffa03e8402>] ? thinkpad_acpi_module_init.part.32+0x5f6/0x925 [thinkpad_acpi] >> [ 2.385085] [<ffffffffa03e8731>] ? thinkpad_acpi_module_init.part.32+0x925/0x925 [thinkpad_acpi] >> [ 2.385152] [<ffffffffa03e8a83>] ? thinkpad_acpi_module_init+0x352/0x8cf [thinkpad_acpi] >> [ 2.385216] [<ffffffff8115092b>] ? free_pcppages_bulk+0xbb/0x480 >> [ 2.385271] [<ffffffff81002122>] ? do_one_initcall+0xb2/0x200 >> [ 2.385323] [<ffffffff8114846b>] ? do_init_module+0x5b/0x1e0 >> [ 2.385373] [<ffffffff810e366e>] ? load_module+0x220e/0x2810 >> [ 2.385427] [<ffffffff810dff70>] ? __symbol_put+0x30/0x30 >> [ 2.385484] [<ffffffff810e3e50>] ? SyS_finit_module+0x90/0xc0 >> [ 2.385535] [<ffffffff814fa832>] ? entry_SYSCALL_64_fastpath+0x16/0x71 >> [ 2.385588] Code: 48 89 df e8 0e 24 bb ff 48 8d 43 20 48 8d 74 24 10 48 89 c1 48 89 44 24 08 48 8b 43 28 48 89 4c 24 10 48 89 73 28 48 89 44 24 18 <48> 89 30 4c 89 6c 24 20 8b 03 85 c0 78 0e 44 89 f0 87 03 83 f8 >> [ 2.387856] RIP [<ffffffff814f8655>] __mutex_lock_slowpath+0xd5/0x2f0 >> [ 2.387945] RSP <ffff880035e07b40> >> [ 2.387993] CR2: 0000000000000000 >> [ 2.388042] ---[ end trace 60661306144c0867 ]--- >> [ 2.392773] [drm] Initialized drm 1.1.0 20060810 >> [ 2.415803] tpm_tis 00:05: TPM is disabled/deactivated (0x6) >> [ 2.431086] wmi: Mapper loaded >> [...] >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists