linux-kernel - [PATCH] scsi: mvsas: fix indenting on return error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1451995000-9210-1-git-send-email-colin.king@canonical.com>
Date:	Tue,  5 Jan 2016 11:56:40 +0000
From:	Colin King <colin.king@...onical.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Tomas Henzl <thenzl@...hat.com>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	linux-scsi@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: mvsas: fix indenting on return error code

From: Colin Ian King <colin.king@...onical.com>

The return code and error return is incorrectly indented which
may cause some confusion as it appears at first sight to be associated
with a device not ready error (with missing { } braces) rather than
a DEV_IS_GONE() failure.

The incorrect indenting was introduced by commit
0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
for Task collector mode and fixed relative bugs")

No functional change, just a minor code reformatting clean up.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/scsi/mvsas/mv_sas.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 9c78074..e712fe7 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
 			mv_dprintk("device %016llx not ready.\n",
 				SAS_ADDR(dev->sas_addr));
 
-			rc = SAS_PHY_DOWN;
-			return rc;
+		rc = SAS_PHY_DOWN;
+		return rc;
 	}
 	tei.port = dev->port->lldd_port;
 	if (tei.port && !tei.port->port_attached && !tmf) {
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/