linux-kernel - Re: [PATCH] of/platform: export of_default_bus_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLrt5s1igeA3=9kWDy+BD1Dvd6DfmBgU0Nc6PxUwdRG4w@mail.gmail.com>
Date:	Tue, 5 Jan 2016 08:21:33 -0600
From:	Rob Herring <robh+dt@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Olof Johansson <olof@...om.net>,
	Frank Rowand <frowand.list@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH] of/platform: export of_default_bus_match_table

On Tue, Jan 5, 2016 at 5:48 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 05 January 2016 19:50:31 Masahiro Yamada wrote:
>> 2016-01-05 19:13 GMT+09:00 Arnd Bergmann <arnd@...db.de>:
>> > On Tuesday 05 January 2016 11:17:53 Masahiro Yamada wrote:
>>
>> This bus is used to connect external (on-board) devices with the SoC.
>>
>> So, no possibility for AMBA, but
>> I want "simple-bus" for grouping some device nodes.
>> Also, "simple-mfd" would be useful because an external device could be an MFD.
>>
>>
>> Please see arch/arm/boot/dts/uniphier-support-card.dtsi
>>
>> It describes an add-on card (expansion board)
>> which has ETHER, UART, etc. on it.
>>
>> I implemented it as "simple-bus".
>>
>> This card is connected to the chip select 1
>> of the UniPhier System Bus.
>>
>
> Ok, got it. So you could alternatively define your own match table
> in the driver with just "simple-bus" and  "simple-mfd". I think either
> way is fine, let's see what the DT maintainers prefer.

I'd like a wrapper function here and try to eliminate non-default
matches (as well as auxdata). All but a few callers pass either
of_default_bus_match_table or NULL (populate only the immediate
children). So no, I don't want to see more match tables. It shouldn't
hurt to have extra entries in the match table (BTW, we should also
kill off "amba-bus" which is an ambiguous term).

If the wrapper was done as a static inline, we'd still need this
export, so I'm fine with this change and will apply it.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/