linux-kernel - Re: [PATCH 0/2] Asus Wireless Radio Control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+A7VXWZnFsudjK9znpPDonapVzhbYD78o_KsBzNWCSrvDtO0w@mail.gmail.com>
Date:	Tue, 5 Jan 2016 11:18:27 -0500
From:	João Paulo Rechi Vita <jprvita@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	Corentin Chary <corentin.chary@...il.com>,
	platform-driver-x86@...r.kernel.org,
	acpi4asus-user@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	João Paulo Rechi Vita <jprvita@...lessm.com>
Subject: Re: [PATCH 0/2] Asus Wireless Radio Control driver

On 5 January 2016 at 08:58, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> On Tue, Jan 5, 2016 at 3:25 PM, João Paulo Rechi Vita <jprvita@...il.com> wrote:
>> This series implements the driver for the "Asus Wireless Radio Control" device,
>> as named on the vendor website, which handles notifications from the airplane
>> mode hotkey and drives the airplane mode indicator LED. This device appears in
>> the DSDT as "ASHS".
>>
>> I decided to split the series and move the commits that drive the LED to a
>> separate series, so this part can be merged without waiting for feedback on the
>> new airplane mode RFKill LED trigger.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>
> (I'm fine with current version but please take into consideration
> comments to the first patch, most important 'default m' thing)
>

I wasn't really sure about the "default m", so I've followed your
suggestions and just sent an updated patch in reply to that one.
Thanks for your review, it certainly made the code a lot better.

--
João Paulo Rechi Vita
http://about.me/jprvita
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/