linux-kernel - Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160106.012326.1058946039396006074.davem@davemloft.net>
Date:	Wed, 06 Jan 2016 01:23:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jarod@...hat.com
Cc:	linux-kernel@...r.kernel.org, eugene.shatokhin@...alab.ru,
	prudy1@...pl, jcliburn@...il.com, chris.snook@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing
 and padding

From: Jarod Wilson <jarod@...hat.com>
Date: Tue,  5 Jan 2016 18:12:34 -0500

> -	if ((raw_mtu + 8) < ALX_TXQ1_JUMBO_TSO_TH)
> -		val = (raw_mtu + 8 + 7) >> 3;
> +	if ((raw_mtu) < ALX_TXQ1_JUMBO_TSO_TH)
> +		val = (raw_mtu + 7) >> 3;

The parenthesis around 'raw_mtu' is superfluous, please
remove it.

Otherwise this looks great, please resubmit with that fixed
up.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/