linux-kernel - Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568C9534.3050700@rock-chips.com>
Date:	Wed, 6 Jan 2016 12:16:52 +0800
From:	Chris Zhong <zyw@...k-chips.com>
To:	Mark yao <mark.yao@...k-chips.com>, heiko@...ech.de,
	linux-rockchip@...ts.infradead.org, treding@...dia.com
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	airlied@...ux.ie, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

Hi Mark


On 01/06/2016 09:48 AM, Mark yao wrote:
> On 2015年12月23日 11:43, Chris Zhong wrote:
>> +static int dw_mipi_dsi_register(struct drm_device *drm,
>> +                      struct dw_mipi_dsi *dsi)
>> +{
>> +    struct drm_encoder *encoder = &dsi->encoder;
>> +    struct drm_connector *connector = &dsi->connector;
>> +    struct device *dev = dsi->dev;
>> +    int ret;
>> +
>> +    encoder->possible_crtcs = drm_of_find_possible_crtcs(drm,
>> +                                 dev->of_node);
>> +    /*
>> +     * If we failed to find the CRTC(s) which this encoder is
>> +     * supposed to be connected to, it's because the CRTC has
>> +     * not been registered yet.  Defer probing, and hope that
>> +     * the required CRTC is added later.
>> +     */
>> +    if (encoder->possible_crtcs == 0)
>> +        return -EPROBE_DEFER;
>> +
>> +    drm_encoder_helper_add(&dsi->encoder,
>> +                   &dw_mipi_dsi_encoder_helper_funcs);
>> +    ret = drm_encoder_init(drm, &dsi->encoder, 
>> &dw_mipi_dsi_encoder_funcs,
>> +             DRM_MODE_ENCODER_DSI);
>> +    if (ret) {
>> +        dev_err(dev, "Failed to initialize encoder with drm\n");
>> +        return ret;
>> +    }
>> +
>> +    drm_connector_helper_add(connector,
>> +            &dw_mipi_dsi_connector_helper_funcs);
>> +
>> +    drm_connector_init(drm, &dsi->connector,
>> +               &dw_mipi_dsi_atomic_connector_funcs,
>> +               DRM_MODE_CONNECTOR_DSI);
>> +
> Hi Chris
>
> I try to pick your patches, but found following issues:
>
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中:
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 
> ‘drm_encoder_init’的实参太少
> include/drm/drm_crtc.h:2220:5: 附注： 在此声明
> make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1
>
> Can you rebase to newest Dave's drm-next and fix this problem?
Thanks Mark.
I have post the v7 serial, fix this this compile err and modify the 
config to tristate for modules build
>
> Thanks.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/