[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160106100712.GA2790@e104805>
Date: Wed, 6 Jan 2016 10:07:13 +0000
From: Javi Merino <javi.merino@....com>
To: Leo Yan <leo.yan@...aro.org>
Cc: Jonathan Corbet <corbet@....net>, Zhang Rui <rui.zhang@...el.com>,
Eduardo Valentin <edubezval@...il.com>,
Punit Agrawal <punit.agrawal@....com>,
Daniel Kurtz <djkurtz@...omium.org>, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
Daniel Thompson <daniel.thompson@...aro.org>
Subject: Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update
sustainable power
On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote:
> k_po/k_pu are two proportional term constants and essentially they have
> fixed ratio compared with sustainable power. In current implementation,
> k_po and k_pu are absolute value after calculation and cannot represent
> the ratio relationship with sustainable power; as a result, when change
> sustainable power we cannot smoothly change proportional term constant.
In v2 Daniel said that the use case was made up. Can you elaborate on
why we need this?
> So this patch series introduces k_po_ratio and k_pu_ratio, which
> represent the ratio value compared against sustainable power. Also add
> sys file system nodes for them for easily update them from userspace and
> update a bit in documentation.
Actually, it makes it harder to update from userspace. Now userspace
can't set a k_po/k_pu any more, and it's forced to set them as ratios
of sustainable power. I'd rather not do this unless there is a good
reason for it.
Cheers,
Javi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists