linux-kernel - Re: [patch] mtip32xx: calling kfree() on an error pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160106131650.GH23363@mwanda>
Date:	Wed, 6 Jan 2016 16:16:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Jens Axboe <axboe@...com>,
	Asai Thambi SP <asamymuthupa@...ron.com>,
	Selvan Mani <smani@...ron.com>, Jeff Moyer <jmoyer@...hat.com>,
	Michal Hocko <mhocko@...e.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer

On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > which is a bug.
> 
> Mind if I fold it (with credit, obviously)?

No problem, that's fine.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/