linux-kernel - Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452099937.2768.123.camel@decadent.org.uk>
Date:	Wed, 06 Jan 2016 17:05:37 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Kamal Mostafa <kamal@...onical.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, kernel-team@...ts.ubuntu.com
Cc:	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a
 short transfer event mid TD

On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote:
> 4.2.8-ckt1 -stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Mathias Nyman <mathias.nyman@...ux.intel.com>
> 
> commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream.
> 
> If the difference is big enough between the bytes asked and received
> in a bulk transfer we can get a short transfer event pointing to a TRB in
> the middle of the TD. We don't want to handle the TD yet as we will anyway
> receive a new event for the last TRB in the TD.
> 
> Hold off from finishing the TD and removing it from the list until we
> receive an event for the last TRB in the TD
> 
> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> [ kamal: backport to 4.2-stable: context ]
> Signed-off-by: Kamal Mostafa <kamal@...onical.com>
[...]

This causes regressions (see https://bugs.debian.org/808602 and
https://bugs.debian.org/808953 ) so please hold off until there's a
complete fix upstream.

Ben.

-- 
Ben Hutchings
It is easier to write an incorrect program than to understand a correct one.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)