linux-kernel - Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2016 11:08:44 -0600
From:	Rob Herring <robh@...nel.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	SH-Linux <linux-sh@...r.kernel.org>,
	Magnus Damm <magnus.damm@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Jan Luebbe <jlu@...gutronix.de>
Subject: Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver

On Wed, Jan 6, 2016 at 7:51 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
> From: Wolfram Sang <wsa+renesas@...g-engineering.com>
>
> This driver allows an I2C bus to switch between multiple masters. This
> is not hot-swichting because connected I2C slaves will be
> re-instantiated. It is meant to select the best I2C core at runtime once
> the task is known. Example: Prefer i2c-gpio over another I2C core
> because of HW errata affetcing your use case.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

[...]

> +static int i2c_demux_activate_master(struct i2c_demux_pinctrl_priv *priv, u32 new_chan)
> +{
> +       struct i2c_adapter *adap;
> +       struct pinctrl *p;
> +       int ret;
> +
> +       mutex_lock(&of_mutex);
> +       ret = of_changeset_apply(&priv->chan[new_chan].chgset);
> +       mutex_unlock(&of_mutex);

Looks like you need this patch[1] rather than exposing of_mutex.

Rob

[1] https://patchwork.ozlabs.org/patch/539938/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/