linux-kernel - Re: [PATCH] scsi: mvsas: fix indenting on return error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1y4c2ih9s.fsf@sermon.lab.mkp.net>
Date:	Wed, 06 Jan 2016 15:29:03 -0500
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Colin King <colin.king@...onical.com>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Tomas Henzl <thenzl@...hat.com>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: mvsas: fix indenting on return error code

>>>>> "Colin" == Colin King <colin.king@...onical.com> writes:

Colin,

Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure.

This problem has already been addressed:

https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/