linux-kernel - Re: [PATCH v2 2/4] clk: arizona: Add clock driver for the Arizona devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201601070556.nSZh6xQZ%fengguang.wu@intel.com>
Date:	Thu, 7 Jan 2016 05:47:26 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	kbuild-all@...org, mturquette@...libre.com, cw00.choi@...sung.com,
	lee.jones@...aro.org, sboyd@...eaurora.org,
	myungjoo.ham@...sung.com, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2 2/4] clk: arizona: Add clock driver for the Arizona
 devices

Hi Charles,

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v4.4-rc8 next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160106-203745
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

Note: the linux-review/Charles-Keepax/extcon-arizona-Remove-enable-disable-of-32k-clock/20160106-203745 HEAD 3b9e1c414d26bbf32acebb42a19ac902535a58b7 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/clk/clk-arizona.c: In function 'arizona_clk_of_get_pdata':
>> drivers/clk/clk-arizona.c:92:3: error: implicit declaration of function 'of_clk_get_by_name' [-Werror=implicit-function-declaration]
      mclk = of_clk_get_by_name(arizona->dev->of_node, pins[i]);
      ^
   drivers/clk/clk-arizona.c:92:8: warning: assignment makes pointer from integer without a cast
      mclk = of_clk_get_by_name(arizona->dev->of_node, pins[i]);
           ^
>> drivers/clk/clk-arizona.c:96:3: error: implicit declaration of function 'clk_get_rate' [-Werror=implicit-function-declaration]
      if (clk_get_rate(mclk) == CLK32K_RATE) {
      ^
>> drivers/clk/clk-arizona.c:101:3: error: implicit declaration of function 'clk_put' [-Werror=implicit-function-declaration]
      clk_put(mclk);
      ^
   cc1: some warnings being treated as errors

vim +/of_clk_get_by_name +92 drivers/clk/clk-arizona.c

    86		int i;
    87	
    88		if (!of_property_read_bool(arizona->dev->of_node, "clocks"))
    89			return 0;
    90	
    91		for (i = 0; i < ARRAY_SIZE(pins); ++i) {
  > 92			mclk = of_clk_get_by_name(arizona->dev->of_node, pins[i]);
    93			if (IS_ERR(mclk))
    94				return PTR_ERR(mclk);
    95	
  > 96			if (clk_get_rate(mclk) == CLK32K_RATE) {
    97				arizona->pdata.clk32k_src = ARIZONA_32KZ_MCLK1 + i;
    98				arizona->pdata.clk32k_parent = __clk_get_name(mclk);
    99			}
   100	
 > 101			clk_put(mclk);
   102		}
   103	
   104		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (43310 bytes)