linux-kernel - Re: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568E1869.3050608@ti.com>
Date:	Thu, 7 Jan 2016 16:48:57 +0900
From:	Milo Kim <milo.kim@...com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	<tglx@...utronix.de>, <jason@...edaemon.net>,
	<marc.zyngier@....com>, <alexandre.belloni@...e-electrons.com>,
	<ludovic.desroches@...el.com>, <nicolas.ferre@...el.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver

Hi Boris,

>> If AIC and AIC5 must be separate, then I'll try to rework
>> irq-atmel-common part.
>
> What would you like to rework? Could you describe in more details
> what's bothering you in this code?

I was about to modify irq-atmel-aic-common as below.

   * AIC5 handles for-loop twice during initialization.
   1) after IRQ generic chip is allocated successfully.
   2) map AIC5 IRQ chip operation after aic_common_of_init() returns.
   To reduce for-loop count, move each IRQ chip initialization code into 
common part.

   * AIC and AIC5 have same interrupt handling procedure, so each IRQ 
handler can be moved to common part.

BTW, I've sent another patch-set about fixing few things. Could you 
check them?

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/