linux-kernel - Re: [PATCH] s390: drop smp_mb in vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568E24C1.7090109@de.ibm.com>
Date:	Thu, 7 Jan 2016 09:41:37 +0100
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: drop smp_mb in vdso_init

On 01/05/2016 05:17 PM, Michael S. Tsirkin wrote:
> The initial s390 vdso code is heavily influenced by the powerpc version
> which does have a smp_wmb in vdso_init right before the vdso_ready=1
> assignment. s390 has no need for that.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
> 
> Untested.
> 
>  arch/s390/kernel/vdso.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 59eddb0..a1cfd37 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -299,8 +299,6 @@ static int __init vdso_init(void)
> 
>  	get_page(virt_to_page(vdso_data));
> 
> -	smp_mb();
> -
>  	return 0;
>  }
>  early_initcall(vdso_init);
> 

applied to the s390 tree.
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/