linux-kernel - Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2016 13:34:12 +0100
From:	Joerg Roedel <joro@...tes.org>
To:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Cc:	bp@...en8.de, peterz@...radead.org, mingo@...hat.com,
	acme@...nel.org, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max
 banks and counters

On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote:
> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid,
> which should not be the case. Also, these don't properly support
> multi-IOMMU system.
> 
> Current and future AMD systems with IOMMU that support perf counter
> would likely contain homogeneous IOMMUs where multiple IOMMUs are
> availalbe. So, this patch modifies these function to iterate all IOMMU
> to check the max banks and counters reported by the hardware.
> 
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> ---
>  arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++----------
>  drivers/iommu/amd_iommu_init.c             | 20 ++++++++++++--------
>  include/linux/perf/perf_event_amd_iommu.h  |  7 ++-----
>  3 files changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Joerg Roedel <jroedel@...e.de>

This looks like the fix for the CZ issue, right? If true, it is
probably v4.5 material.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/