linux-kernel - Re: [PATCH] soc: qcom: Add support for SAW2 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568E6C8F.6020509@linaro.org>
Date:	Thu, 7 Jan 2016 15:47:59 +0200
From:	Georgi Djakov <georgi.djakov@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	andy.gross@...aro.org, lina.iyer@...aro.org, sboyd@...eaurora.org,
	linux-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: Add support for SAW2 regulators

On 12/18/2015 07:22 PM, Mark Brown wrote:
> On Fri, Dec 18, 2015 at 06:14:58PM +0200, Georgi Djakov wrote:
>> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper)
>> is part of the SPM subsystem. It is a hardware block found on some of the
>> Qualcomm chipsets, which regulates the power to the CPU cores. Add some
>> basic support for it, so that we can do dynamic voltage scaling.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@...aro.org>
>> ---
>>  drivers/soc/qcom/spm.c |  149 +++++++++++++++++++++++++++++++++++++++++++++++-
> 
> Please don't implement regualtors outside of the regulator driver
> directory unless there is a really strong reason to do so, it makes it
> much easier to maintain the subsystem and keep track of what's going on.
> 

The reason of implementing the regulator functionality in drivers/soc is
that it is part of the same hardware. The saw2 hardware manages the power
controls - switching to low-power sleep modes, adaptive voltage scaling,
voltage control and messaging to the PMIC. Keeping all the functionality
of this hardware into a single driver seemed the suitable approach to me.
But if you think this is not a strong reason, then the approach probably
would be to export parts of the existing driver and use syscon from a
separate driver in drivers/regulator?

Thanks,
Georgi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/