linux-kernel - Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160107155032.GB1898@mtj.duckdns.org>
Date:	Thu, 7 Jan 2016 10:50:32 -0500
From:	Tejun Heo <tj@...nel.org>
To:	wanghaibin <wanghaibin.wang@...wei.com>
Cc:	linux-kernel@...r.kernel.org, jiangshanlai@...il.com,
	peter.huangpeng@...wei.com
Subject: Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource
 when wq_numa_init failed.

On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote:
> Before the return that wq_numa_init failed, it will be bettet to free
> the numa node table to avoid the memory leaks.

That's a WARN_ON condition which should never happen.  The system is
already pretty messed up and just limping along.  It really doesn't
matter whether some memory is cleaned up or not.  Let's keep it
simple.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/