linux-kernel - Re: net-thunder: One check less in nicvf_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568EC2FD.9000702@users.sourceforge.net>
Date:	Thu, 7 Jan 2016 20:56:45 +0100
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Robert Richter <rric@...nel.org>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Sunil Goutham <sgoutham@...ium.com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: net-thunder: One check less in nicvf_register_interrupts() after
 error detection

>> Is it a bit more efficient to avoid a double check for the
>> variable "ret" at the end of the current implementation for the
>> discussed function?
> 
> Before asking questions you could answer yourself,
> please look at object code produced by the compiler
> before and after your proposed changes.

* Do any more source code reviewers wonder about the need
  for such a double check?

* Which object code representations would you find representative
  for a further constructive discussion around this
  software component?

Regards,
Markus