linux-kernel - Re: [PATCH v2 1/5] test: firmware_class: report errors properly on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568ED085.4040801@osg.samsung.com>
Date:	Thu, 7 Jan 2016 13:54:29 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ming Lei <ming.lei@...onical.com>
Cc:	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
	linux-api@...r.kernel.org, "Luis R. Rodriguez" <mcgrof@...e.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2 1/5] test: firmware_class: report errors properly on
 failure

On 12/09/2015 03:50 PM, Brian Norris wrote:
> request_firmware() failures currently won't get reported at all (the
> error code is discarded). What's more, we get confusing messages, like:
> 
>     # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
>     [ 8280.311856] test_firmware: loading 'notafile'
>     [ 8280.317042] test_firmware: load of 'notafile' failed: -2
>     [ 8280.322445] test_firmware: loaded: 0
>     # echo $?
>     0
> 
> Report the failures via write() errors, and don't say we "loaded"
> anything.
> 
> Signed-off-by: Brian Norris <computersforpeace@...il.com>
> Acked-by: Kees Cook <keescook@...omium.org>

Thanks for fixing it. Applied to linux-kselftest next for 4.5-rc1.

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978