linux-kernel - Re: [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568ED119.8040905@osg.samsung.com>
Date:	Thu, 7 Jan 2016 13:56:57 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ming Lei <ming.lei@...onical.com>
Cc:	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
	linux-api@...r.kernel.org, "Luis R. Rodriguez" <mcgrof@...e.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2 4/5] firmware: actually return NULL on failed
 request_firmware_nowait()

On 12/09/2015 03:50 PM, Brian Norris wrote:
> The kerneldoc for request_firmware_nowait() says that it may call the
> provided cont() callback with @fw == NULL, if the firmware request
> fails. However, this is not the case when called with an empty string
> (""). This case is short-circuited by the 'name[0] == '\0'' check
> introduced in commit 471b095dfe0d ("firmware_class: make sure fw requests
> contain a name"), so _request_firmware() never gets to set the fw to
> NULL.
> 

Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.

thanks,
-- Shuah
-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978