linux-kernel - Re: [PATCH V2 1/8] perf: Add PERF_SAMPLE_PHYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201601080526.eeSgYDgo%fengguang.wu@intel.com>
Date:	Fri, 8 Jan 2016 05:22:02 +0800
From:	kbuild test robot <lkp@...el.com>
To:	kan.liang@...el.com
Cc:	kbuild-all@...org, peterz@...radead.org, acme@...nel.org,
	eranian@...gle.com, ak@...ux.intel.com, jolsa@...nel.org,
	namhyung@...nel.org, linux-kernel@...r.kernel.org,
	Kan Liang <kan.liang@...el.com>
Subject: Re: [PATCH V2 1/8] perf: Add PERF_SAMPLE_PHYS_ADDR

Hi Kan,

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.4-rc8 next-20160107]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/kan-liang-intel-com/perf-Add-PERF_SAMPLE_PHYS_ADDR/20160108-045715
config: x86_64-randconfig-x006-01060743 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   arch/x86/kernel/cpu/perf_event_intel_ds.c: In function 'setup_pebs_sample_data':
>> arch/x86/kernel/cpu/perf_event_intel_ds.c:1087:28: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration]
        data->phys_addr = (u64)virt_to_phys((void *)data->addr);
                               ^
>> arch/x86/kernel/cpu/perf_event_intel_ds.c:1098:23: error: implicit declaration of function 'page_to_phys' [-Werror=implicit-function-declaration]
        data->phys_addr = page_to_phys(p) + data->addr % PAGE_SIZE;
                          ^
   cc1: some warnings being treated as errors

vim +/virt_to_phys +1087 arch/x86/kernel/cpu/perf_event_intel_ds.c

  1081	
  1082		if ((sample_type & PERF_SAMPLE_PHYS_ADDR) && (data->addr != 0)) {
  1083			if (data->addr >= TASK_SIZE) {
  1084				/* If it's vmalloc()d memory, leave phys_addr as 0 */
  1085				if (virt_addr_valid(data->addr) &&
  1086				    !(data->addr >= VMALLOC_START && data->addr < VMALLOC_END))
> 1087					data->phys_addr = (u64)virt_to_phys((void *)data->addr);
  1088			} else {
  1089				/*
  1090				 * Walking the pages tables for user address.
  1091				 * Interrupts are disabled, so it prevents any tear down
  1092				 * of the page tables.
  1093				 * Try IRQ-safe __get_user_pages_fast first.
  1094				 * If failed, leave phys_addr as 0.
  1095				 */
  1096				if ((current->mm != NULL) &&
  1097				    (__get_user_pages_fast(data->addr, 1, 0, &p) == 1))
> 1098					data->phys_addr = page_to_phys(p) + data->addr % PAGE_SIZE;
  1099	
  1100				if (p)
  1101					put_page(p);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (20341 bytes)