linux-kernel - Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568EF9F9.8050404@oracle.com>
Date:	Thu, 7 Jan 2016 15:51:21 -0800
From:	Mike Kravetz <mike.kravetz@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Hillf Danton <hillf.zj@...baba-inc.com>,
	Hugh Dickins <hughd@...gle.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list

On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu,  7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@...cle.com> wrote:
> 
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t.  It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range.  However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop.  In addition, the conversion of end to vaddr offset
>> was incorrect.
> 
> Could we please have a description of the user-visible effects of the
> bug?  It's always needed for -stable things.  And for all bugfixes, really.
> 
> (stable@...r.kernel.org[4.3] isn't an email address btw - my client barfed)

Will do.

As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct.  An update will come after more study.

-- 
Mike Kravetz