linux-kernel - Re: [PATCH] ACPI, PCI, irq: remove redundant check for null string pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1690153.ze76fKGfdG@vostro.rjw.lan>
Date:	Fri, 08 Jan 2016 01:45:32 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Colin King <colin.king@...onical.com>
Cc:	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI, PCI, irq: remove redundant check for null string pointer

On Tuesday, January 05, 2016 10:57:11 AM Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> source is decleared as a 4 byte char array in struct acpi_pci_routing_table
> so !prt->source is a redundant null string pointer check. Detected with
> smatch:
> 
> drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
>   non-NULL. 'prt->source'
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks!

> ---
>  drivers/acpi/pci_irq.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index c933675..d30184c 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry,
>  		quirk = &prt_quirks[i];
>  
>  		/* All current quirks involve link devices, not GSIs */
> -		if (!prt->source)
> -			continue;
> -
>  		if (dmi_check_system(quirk->system) &&
>  		    entry->id.segment == quirk->segment &&
>  		    entry->id.bus == quirk->bus &&
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.