linux-kernel - RE: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DDB9C85B850785449757F9914A034FCB4450942A@G9W0766.americas.hpqcorp.net>
Date:	Fri, 8 Jan 2016 04:29:36 +0000
From:	"Seymour, Shane M" <shane.seymour@....com>
To:	John Garry <john.garry@...wei.com>,
	"JBottomley@...n.com" <JBottomley@...n.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:	"linuxarm@...wei.com" <linuxarm@...wei.com>,
	"zhangfei.gao@...aro.org" <zhangfei.gao@...aro.org>,
	"xuwei5@...ilicon.com" <xuwei5@...ilicon.com>,
	"john.garry2@...l.dcu.ie" <john.garry2@...l.dcu.ie>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1_hw()

> By reading in itct.qw0 into a 32b variable the top
> 32 bits were being lost.
> In practice this was OK as they were zeroes.
> 
> Fixes: 27a3f229 ("hisi_sas: Add cq interrupt")
> 
> Signed-off-by: John Garry <john.garry@...wei.com>

Reviewed-by: Shane Seymour <shane.seymour@....com>