linux-kernel - Re: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AC4CAD57-D230-4F26-9DCB-2F1FCECBCC4E@linux.vnet.ibm.com>
Date:	Thu, 7 Jan 2016 22:51:10 -0600
From:	"Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:	John Garry <john.garry@...wei.com>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
	john.garry2@...l.dcu.ie, linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] hisi_sas: use u64 for qw0 in free_device_v1_hw()

> On Dec 21, 2015, at 5:35 AM, John Garry <john.garry@...wei.com> wrote:
> 
> By reading in itct.qw0 into a 32b variable the top
> 32 bits were being lost.
> In practice this was OK as they were zeroes.
> 
> Fixes: 27a3f229 ("hisi_sas: Add cq interrupt")
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index 38ff575..057fdeb 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -539,7 +539,8 @@ static void free_device_v1_hw(struct hisi_hba *hisi_hba,
> {
> 	u64 dev_id = sas_dev->device_id;
> 	struct hisi_sas_itct *itct = &hisi_hba->itct[dev_id];
> -	u32 qw0, reg_val = hisi_sas_read32(hisi_hba, CFG_AGING_TIME);
> +	u64 qw0;

This should probably be a __le64, but not a big deal.

Reviewed-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>