[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <568F73D2.2090808@sandisk.com>
Date: Fri, 8 Jan 2016 09:31:14 +0100
From: Bart Van Assche <bart.vanassche@...disk.com>
To: Christoph Hellwig <hch@....de>,
"Nicholas A. Bellinger" <nab@...erainc.com>
CC: target-devel <target-devel@...r.kernel.org>,
linux-scsi <linux-scsi@...r.kernel.org>,
lkml <linux-kernel@...r.kernel.org>,
"Sagi Grimberg" <sagig@...lanox.com>,
Hannes Reinecke <hare@...e.de>,
Andy Grover <agrover@...hat.com>,
Vasu Dev <vasu.dev@...ux.intel.com>, Vu Pham <vu@...lanox.com>,
Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during
get_initiator_node_acl
On 01/08/2016 09:14 AM, Christoph Hellwig wrote:
>> mutex_lock(&tpg->acl_node_mutex);
>> acl = __core_tpg_get_initiator_node_acl(tpg, initiatorname);
>> + /*
>> + * Obtain the acl_kref now, which will be dropped upon the
>> + * release of se_sess memory within transport_free_session().
>> + */
>> + if (acl)
>> + kref_get(&acl->acl_kref);
>
> І think the comment is highly confusing as it's about one of the
> callers, while the function has many.
>
> I'd suggest you move it to core_tpg_check_initiator_node_acl instead.
>
> Also I think iscsit_build_sendtargets_response will need a put on
> the nacl, otherwise you'll leak references.
Indeed. All error paths in all target drivers will have to be modified
to avoid that an acl reference leak is triggered if
transport_init_session() fails after core_tpg_check_initiator_node_acl()
succeeded.
Bart.
Powered by blists - more mailing lists