linux-kernel - Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of __clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568F0684.6060701@mleia.com>
Date:	Fri, 08 Jan 2016 02:44:52 +0200
From:	Vladimir Zapolskiy <vz@...ia.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	linux-clk@...r.kernel.org
CC:	Stephen Boyd <sboyd@...eaurora.org>,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of
 __clk_init()

Hi,

the whole series looks very good, also I haven't found any regressions
(tested on imx6q and lpc32xx).

Please feel free to add

Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>

On 28.12.2015 12:22, Masahiro Yamada wrote:
> The "struct device *dev" is not used at all in this function.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/clk/clk.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 3fba5ac..897e5ae 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2286,13 +2286,12 @@ static inline void clk_debug_unregister(struct clk_core *core)
>  
>  /**
>   * __clk_init - initialize the data structures in a struct clk
> - * @dev:	device initializing this clk, placeholder for now
>   * @clk:	clk being initialized
>   *
>   * Initializes the lists in struct clk_core, queries the hardware for the
>   * parent and rate and sets them both.
>   */
> -static int __clk_init(struct device *dev, struct clk *clk_user)
> +static int __clk_init(struct clk *clk_user)
>  {
>  	int i, ret = 0;
>  	struct clk_core *orphan;
> @@ -2575,7 +2574,7 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw)
>  		goto fail_parent_names_copy;
>  	}
>  
> -	ret = __clk_init(dev, hw->clk);
> +	ret = __clk_init(hw->clk);
>  	if (!ret)
>  		return hw->clk;
>  
> 

--
With best wishes,
Vladimir