lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Jan 2016 14:01:00 +0000 (GMT) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: Rafał Miłecki <zajec5@...il.com> cc: Brian Norris <computersforpeace@...il.com>, Javier Martinez Canillas <javier@....samsung.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Fengguang Wu <fengguang.wu@...el.com>, Michael Ellerman <mpe@...erman.id.au>, Luis de Bethencourt <luisbg@....samsung.com>, Jeremy Kerr <jk@...abs.org>, Neelesh Gupta <neelegup@...ux.vnet.ibm.com>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, David Woodhouse <dwmw2@...radead.org>, Cyril Bur <cyrilbur@...il.com> Subject: Re: [PATCH] mtd: bcm47xxsflash: use devm_ioremap_nocache() instead of KSEG0ADDR() On Fri, 8 Jan 2016, Rafał Miłecki wrote: > > This removes some (implicit) MIPS dependencies and makes the code more > > portable, whether we need it or not :) > > So now we have following forwardtrace: > devm_ioremap_nocache > ioremap_nocache > __ioremap_mode > __ioremap > CKSEG1ADDR > > It results in different address than KSEG0ADDR: > [ 1.339752] [bcm47xxsflash_bcma_probe] KSEG0ADDR(BCMA_SOC_FLASH2):9c000000 > [ 1.346848] [bcm47xxsflash_bcma_probe] devm_ioremap_nocache:bc000000 > > But it still works as expected! :) > [ 1.609426] 6 bcm47xxpart partitions found on MTD device bcm47xxsflash > [ 1.616169] Creating 6 MTD partitions on "bcm47xxsflash": It is a functional change though and I think the change from a cached to uncached mapping (i.e. from `ioremap' to `ioremap_nocache') has to be a separate patch, so that both changes can be reviewed independently. Maciej
Powered by blists - more mailing lists