linux-kernel - Re: [PATCH 09/23] hisi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160108150750.GI3097@leverpostej>
Date:	Fri, 8 Jan 2016 15:07:50 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	John Garry <john.garry@...wei.com>
Cc:	JBottomley@...n.com, martin.petersen@...cle.com,
	robh+dt@...nel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
	john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, arnd@...db.de,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 09/23] hisi_sas: add v2 hw init

On Fri, Jan 08, 2016 at 10:15:28PM +0800, John Garry wrote:

> +	/* Global registers init*/
> +	if (of_get_property(np, "am-max-trans", NULL)) {
> +		hisi_sas_write32(hisi_hba, AM_CFG_MAX_TRANS, 0x2020);
> +		hisi_sas_write32(hisi_hba, AM_CFG_SINGLE_PORT_MAX_TRANS,
> +				 0x2020);
> +	}

Use of_property_read_bool for boolean properties like this.

I still don't follow exactly what this property means, and why it is
necessary, but that's an issue for the binding document.

Thanks,
Mark.