[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1452265799-4549-1-git-send-email-rui.y.wang@intel.com>
Date: Fri, 8 Jan 2016 23:09:59 +0800
From: Rui Wang <rui.y.wang@...el.com>
To: miklos@...redi.hu
Cc: viro@...iv.linux.org.uk, linux-unionfs@...r.kernel.org,
linux-kernel@...r.kernel.org, rui.y.wang@...el.com
Subject: [PATCH] ovl: fix getcwd() failure after unsuccessful rmdir
ovl_remove_upper() should do d_drop() only after it successfully
removes the dir, otherwise a subsequent getcwd() system call will
fail, breaking userspace programs.
This is to fix: https://bugzilla.kernel.org/show_bug.cgi?id=110491
Signed-off-by: Rui Wang <rui.y.wang@...el.com>
---
fs/overlayfs/dir.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index 692ceda..36d6a5b 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -618,7 +618,8 @@ static int ovl_remove_upper(struct dentry *dentry, bool is_dir)
* sole user of this dentry. Too tricky... Just unhash for
* now.
*/
- d_drop(dentry);
+ if (!err)
+ d_drop(dentry);
mutex_unlock(&dir->i_mutex);
return err;
--
1.7.5.4
Powered by blists - more mailing lists