linux-kernel - Re: [PATCH 4/4] x86/efi: print size and base in binary units in efi_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcJ_gDs-Y3SO2Z7BRqPCwKXntBiW6UDF38Di5m5_HszWQ@mail.gmail.com>
Date:	Fri, 8 Jan 2016 18:39:28 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Robert Elliott <elliott@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>, linux-efi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap

On Fri, Jan 8, 2016 at 2:19 PM, Matt Fleming <matt@...eblueprint.co.uk> wrote:
> On Sun, 27 Dec, at 04:35:12PM, Andy Shevchenko wrote:
>> On Mon, Dec 21, 2015 at 6:16 PM, Matt Fleming <matt@...eblueprint.co.uk> wrote:
>> >> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
>> >> index 635a955..030ba91 100644
>> >> --- a/arch/x86/platform/efi/efi.c
>> >> +++ b/arch/x86/platform/efi/efi.c
>> >> @@ -222,6 +222,25 @@ int __init efi_memblock_x86_reserve_range(void)
>> >>       return 0;
>> >>  }
>> >>
>> >> +char * __init efi_size_format(char *buf, size_t size, u64 bytes)
>> >> +{
>> >> +     if (!bytes || (bytes & 0x3ff))
>> >> +             snprintf(buf, size, "%llu B", bytes);
>> >> +     else if (bytes & 0xfffff)
>> >> +             snprintf(buf, size, "%llu KiB", bytes >> 10);
>> >> +     else if (bytes & 0x3fffffff)
>> >> +             snprintf(buf, size, "%llu MiB", bytes >> 20);
>> >> +     else if (bytes & 0xffffffffff)
>> >> +             snprintf(buf, size, "%llu GiB", bytes >> 30);
>> >> +     else if (bytes & 0x3ffffffffffff)
>> >> +             snprintf(buf, size, "%llu TiB", bytes >> 40);
>> >> +     else if (bytes & 0xfffffffffffffff)
>> >> +             snprintf(buf, size, "%llu PiB", bytes >> 50);
>> >> +     else
>> >> +             snprintf(buf, size, "%llu EiB", bytes >> 60);
>> >> +     return buf;
>>
>> For me it looks like ffs with name in the table can be used.
>
> Could you provide a patch?

I will prepare something this weekend, or latest next week.

I suppose I can apply Robert's one on top of your efi/next and update it, right?

-- 
With Best Regards,
Andy Shevchenko