lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160108165831.GU1898@mtj.duckdns.org>
Date:	Fri, 8 Jan 2016 11:58:31 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Jan Kara <jack@...e.cz>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	Jeff Moyer <jmoyer@...hat.com>, Jan Kara <jack@...e.com>
Subject: Re: [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big
 thinktime

Hello, Jan.

On Thu, Jan 07, 2016 at 04:28:12PM +0100, Jan Kara wrote:
> @@ -2947,8 +2948,13 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd)
>  		return;
>  	}
>  
> -	/* There are other queues in the group, don't do group idle */
> -	if (group_idle && cfqq->cfqg->nr_cfqq > 1)
> +	/*
> +	 * There are other queues in the group or this is the only group and
> +	 * it has too big thinktime, don't do group idle.
> +	 */
> +	if (group_idle &&
> +	    (cfqq->cfqg->nr_cfqq > 1 ||
> +	     !cfq_io_thinktime_big(cfqd, &st->ttime, true)))
>  		return;

Is the negation in front of the cfq_io_thinktime_big() right?  That
doesn't seem to match the comment or description.  What am I missing?

Thanks.

-- 
tejun

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ