linux-kernel - Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160108204924.GK5354@localhost>
Date:	Fri, 8 Jan 2016 14:49:24 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Tim Sander <tim@...eglstein.org>
Cc:	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org,
	Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI
 Express

[+cc Alex]

On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote:
> Hi
> 
> Please consider this patch for the next release. It won't recognize my Plextor
> M6e PCIE disk without it. Please cc as i am not on the list.
> 
> Signed-off-by: Tim Sander <tim@...eglstein.org>
> 
> PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)

Alex?

Please use a subject line that matches the other similar commits:

  247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120
  c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L
  cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices

> ---
>  drivers/pci/quirks.c    | 4 ++++
>  include/linux/pci_ids.h | 3 +++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7e32730..93ec5a02 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
>                          PCI_DEVICE_ID_JMICRON_JMB388_ESD,
>                          quirk_dma_func1_alias);
> +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */

Thanks for the link.  There are 126 comments on that bugzilla so far,
so it'd be nice to have a more specific pointer.  I'm guessing 117
might be the relevant one, so:

  https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117

> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> +                        PCI_DEVICE_ID_PLEXTOR_M6E,
> +                        quirk_dma_func1_alias);
>  
>  /*
>   * Some devices DMA with the wrong devfn, not just the wrong function.
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index d9ba49c..01d8041 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2501,6 +2501,9 @@
>  
>  #define PCI_VENDOR_ID_ASMEDIA          0x1b21
>  
> +#define PCI_VENDOR_ID_LITE_ON          0x1c28
> +#define PCI_DEVICE_ID_PLEXTOR_M6E      0x0122

Since these constants are only used in one place, don't add them to
pci_ids.h (see comment at the top of this file).  Just use the hex
constants directly in the quirk and include the vendor/device names in
the comment.

>  #define PCI_VENDOR_ID_CIRCUITCO                0x1cc8
>  #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
>  
> -- 
> 1.9.1
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html