linux-kernel - Re: [PATCH trivial] include/linux/dcache.h: Cleanup code and comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 00:16:12 +0800
From:	Chen Gang <chengang@...ndsoft.com.cn>
To:	kbuild test robot <lkp@...el.com>
CC:	kbuild-all@...org, trivial@...nel.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, dhowells@...hat.com,
	nicolas.iooss_linux@....org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH trivial] include/linux/dcache.h: Cleanup code and comments


On 1/9/16 21:27, kbuild test robot wrote:
> Hi Chen,
> 
> [auto build test WARNING on v4.4-rc8]
> [also build test WARNING on next-20160108]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> 
> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/include-linux-dcache-h-Cleanup-code-and-comments/20160109-203554
> reproduce: make htmldocs
> 
> All warnings (new ones prefixed by >>):
> 
>>> include/linux/dcache.h:1: warning: no structured comments found

It looks, we should still reserve "/**" for the comments (my patch use
"/*" instead of "/**").

Thanks.

>    include/linux/jbd2.h:439: warning: No description found for parameter 'i_transaction'
>    include/linux/jbd2.h:439: warning: No description found for parameter 'i_next_transaction'
>    include/linux/jbd2.h:439: warning: No description found for parameter 'i_list'
>    include/linux/jbd2.h:439: warning: No description found for parameter 'i_vfs_inode'
>    include/linux/jbd2.h:439: warning: No description found for parameter 'i_flags'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_rsv_handle'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_reserved'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_type'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_line_no'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_start_jiffies'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_requested_credits'
>    include/linux/jbd2.h:495: warning: No description found for parameter 'h_lockdep_map'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_chkpt_bhs[JBD2_NR_BATCH]'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_devname[BDEVNAME_SIZE+24]'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_average_commit_time'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_min_batch_time'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_max_batch_time'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_commit_callback'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_failed_commit'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_chksum_driver'
>    include/linux/jbd2.h:1038: warning: No description found for parameter 'j_csum_seed'
>    include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s'
>    include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s'
>    include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s'
>    fs/jbd2/transaction.c:429: warning: No description found for parameter 'rsv_blocks'
>    fs/jbd2/transaction.c:429: warning: No description found for parameter 'gfp_mask'
>    fs/jbd2/transaction.c:429: warning: No description found for parameter 'type'
>    fs/jbd2/transaction.c:429: warning: No description found for parameter 'line_no'
>    fs/jbd2/transaction.c:505: warning: No description found for parameter 'type'
>    fs/jbd2/transaction.c:505: warning: No description found for parameter 'line_no'
>    fs/jbd2/transaction.c:635: warning: No description found for parameter 'gfp_mask'
> 
> vim +1 include/linux/dcache.h
> 
> ^1da177e4 Linus Torvalds 2005-04-16 @1  #ifndef __LINUX_DCACHE_H
> ^1da177e4 Linus Torvalds 2005-04-16  2  #define __LINUX_DCACHE_H
> ^1da177e4 Linus Torvalds 2005-04-16  3  
> 60063497a Arun Sharma    2011-07-26  4  #include <linux/atomic.h>
> ^1da177e4 Linus Torvalds 2005-04-16  5  #include <linux/list.h>
> 82524746c Franck Bui-Huu 2008-05-12  6  #include <linux/rculist.h>
> ceb5bdc2d Nick Piggin    2011-01-07  7  #include <linux/rculist_bl.h>
> ^1da177e4 Linus Torvalds 2005-04-16  8  #include <linux/spinlock.h>
> 31e6b01f4 Nick Piggin    2011-01-07  9  #include <linux/seqlock.h>
> 
> :::::: The code at line 1 was first introduced by commit
> :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
> 
> :::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
> :::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed