linux-kernel - Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160109164237.GG3818@linux.vnet.ibm.com>
Date:	Sat, 9 Jan 2016 08:42:37 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	nimisolo <nimisolo@...il.com>
Cc:	josh@...htriplett.org, rostedt@...dmis.org,
	mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs

On Sat, Jan 09, 2016 at 06:23:04AM -0500, nimisolo wrote:
> Maybe it's better to set rdp->core_needs_qs with true/false
> 
> Signed-off-by: nimisolo <nimisolo@...il.com>

Good catch, but someone beat you by about a month.

To check for future changes, please see branch rcu/dev of:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index f07343b..0c0d09d 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
>  	if ((rnp->qsmask & mask) == 0) {
>  		raw_spin_unlock_irqrestore(&rnp->lock, flags);
>  	} else {
> -		rdp->core_needs_qs = 0;
> +		rdp->core_needs_qs = false;
> 
>  		/*
>  		 * This GP can't end until cpu checks in, so all of our
> -- 
> 2.5.0
>