linux-kernel - Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1452360758.672752.487412298.7D14D501@webmail.messagingengine.com>
Date:	Sat, 09 Jan 2016 15:32:38 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Eric Curtin <ericcurtin17@...il.com>,
	David Herrmann <dh.herrmann@...il.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	platform-driver-x86@...r.kernel.org,
	ibm-acpi-devel@...ts.sourceforge.net,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness
 interfaces

On Fri, Jan 8, 2016, at 15:26, Eric Curtin wrote:
> As regards the "Unsupported brightness interface" log message will I
> add 101 to the switch statement so it doesn't get reported on my device
> or just remove it? This seems to be reporting many false positives (or
> negatives whatever way you want to look at it) on different machines so
> can I remove this logging?

Either remove the message, or leave it at debug level.  Do not add 101
to the switch case, please.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh