linux-kernel - Re: [PATCH] m68k: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 10:55:41 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] m68k: fix build failure

On Sun, Jan 10, 2016 at 10:37 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
>> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
>> <sudipm.mukherjee@...il.com> wrote:
>>> The defconfig build of m68k was failing with the error:
>>> implicit declaration of function '__pfn_to_phys'
>>>
>>> Other architectures have added <asm/memory.h>, but if we do so here then
>>> we will also get redeclaration of some other functions. So it is better
>>> to copy these macros into page_mm.h.
>>>
>>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>>> Cc: Dan Williams <dan.j.williams@...el.com>
>>> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
>>
>> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
> Or should I take this through the m68k tree? It's getting a bit late for
> adding new v4.5 stuff...
>
> I see it's already in mm.

I would like to withdraw my Acked-by.

I'm gonna apply it to page.h instead of page_mm.h, to cover the nommu
case, and will queue for v4.5.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds