linux-kernel - Re: [PATCH] irq: action setting before irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1601101112230.3575@nanos>
Date:	Sun, 10 Jan 2016 11:13:35 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: action setting before irq_startup

On Sat, 9 Jan 2016, Yoshinori Sato wrote:

> In non shared and non threaded IRQ case.
> irq_startup calling before desc->action initialize.

And how does that matter? 
 
> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> ---
>  kernel/irq/manage.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 0eebaee..f6cdb63 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1272,6 +1272,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>  		goto out_mask;
>  	}
>  
> +	*old_ptr = new;
> +
>  	if (!shared) {
>  		ret = irq_request_resources(desc);
>  		if (ret) {

So in case irq_request_resources() fails, you leak the action in the irq
descriptor.

Again, what's the problem you are trying to solve?

Thanks,

	tglx