linux-kernel - Re: [PATCH] staging: iio: cdc: Prefer using the BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 11:53:05 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>, lars@...afoo.de,
	Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net,
	gregkh@...uxfoundation.org
Cc:	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: cdc: Prefer using the BIT macro

On 10/01/16 06:20, Bhaktipriya Shridhar wrote:
> Replace all occurences of (1<<x) by BIT(x) in the file ad7150.c to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro"
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Hi,

I'm afraid that a similar patch was sent by Shraddha Barke back at the end
of December.  It just missed the last merge window so can currently only
be found in the testing branch of iio.git.

Thanks anyway. It is always amazing how long code can sit in a given state
before several patches turn up for it in a couple of weeks!

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7150.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index e8d0ff2..0b934f7 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -21,8 +21,8 @@
>   */
> 
>  #define AD7150_STATUS              0
> -#define AD7150_STATUS_OUT1         (1 << 3)
> -#define AD7150_STATUS_OUT2         (1 << 5)
> +#define AD7150_STATUS_OUT1         BIT(3)
> +#define AD7150_STATUS_OUT2         BIT(5)
>  #define AD7150_CH1_DATA_HIGH       1
>  #define AD7150_CH2_DATA_HIGH       3
>  #define AD7150_CH1_AVG_HIGH        5
> @@ -36,7 +36,7 @@
>  #define AD7150_CH2_TIMEOUT         13
>  #define AD7150_CH2_SETUP           14
>  #define AD7150_CFG                 15
> -#define AD7150_CFG_FIX             (1 << 7)
> +#define AD7150_CFG_FIX             BIT(7)
>  #define AD7150_PD_TIMER            16
>  #define AD7150_CH1_CAPDAC          17
>  #define AD7150_CH2_CAPDAC          18
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>