linux-kernel - Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de>
Date:	Sun, 10 Jan 2016 14:38:00 +0100 (CET)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	Måns Rullgård <mans@...sr.com>
Cc:	Sascha Hauer <kernel@...gutronix.de>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on
 pwm2

> Måns Rullgård <mans@...sr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@...e.com> writes:
>
> > Hi Mans,
> >
> >> Mans Rullgard <mans@...sr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> >>
> >>
> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >
> > could you please change your patch to describe why you need to add
> > this pinmux?
>
> I'm working on a board that is wired that way. I can of course put this
> in the board-specific dts if that's preferable.

So the board isn't submitted to mainline?

IMHO the change is okay, but the description doesn't explain why is it needed.

So a suitable description would be that it's needed for board xy.

>
> --
> Måns Rullgård