linux-kernel - Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 16:45:32 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	=adi-buildroot-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed
 API change

On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the bfin_mac driver. This results in the following error message
> 
> drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe':
> drivers/net/ethernet/adi/bfin_mac.c:401:52: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Use phy_find_first() instead of open-coding it.
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Andrew Lunn <andrew@...n.ch>

Hi Dave

Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure
is correct, this one is better. Please take this one in preference. 
We do still however need Sadip's [2/2] bfin_mac: fix error path

   Andrew