linux-kernel - Re: [PATCH 3/4] drivers: ata: wake port before DMA stop for ALPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160110172929.GK3660@htj.duckdns.org>
Date:	Sun, 10 Jan 2016 12:29:29 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Danesh Petigara <dpetigara@...adcom.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com, computersforpeace@...il.com,
	gregory.0xf0@...il.com
Subject: Re: [PATCH 3/4] drivers: ata: wake port before DMA stop for ALPM

Hello, Danesh.

On Fri, Jan 08, 2016 at 03:20:44PM -0800, Danesh Petigara wrote:
> ahci_set_lpm in it's current form cannot be used here as it also
> modifies the ALPE/ASP bits. The idea is to wake the link before DMA stop
> without changing the ALPM bits so the link can return to it's configured
> low power state when it's idle.
> 
> We could however update that function by introducing a new hints flag
> that allows us to skip unneeded logic for this scenario. ahci_set_lpm
> can then be called from ahci_stop_engine.

Yeah, please either update the function or factor the necessary part
out.

Thanks.

-- 
tejun