linux-kernel - Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160110190158.GK24441@pengutronix.de>
Date:	Sun, 10 Jan 2016 20:01:58 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	Måns Rullgård <mans@...sr.com>,
	Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Shawn Guo <shawnguo@...nel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

Hello,

On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote:
> > Måns Rullgård <mans@...sr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> > Stefan Wahren <stefan.wahren@...e.com> writes:
> >
> > > Hi Mans,
> > >
> > >> Mans Rullgard <mans@...sr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> > >>
> > >>
> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> > >
> > > could you please change your patch to describe why you need to add
> > > this pinmux?
> >
> > I'm working on a board that is wired that way. I can of course put this
> > in the board-specific dts if that's preferable.
> 
> So the board isn't submitted to mainline?
> 
> IMHO the change is okay, but the description doesn't explain why is it needed.
> 
> So a suitable description would be that it's needed for board xy.

The problem with pinmuxing on i.MX23/28 is that the order of pinmux
groups is to a certain degree important. So not everything is possible
in the machine specific dts. (I didn't have an eye on this issue, maybe
it's fixed in the meantime?)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |